-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hello_world.md #178
base: main
Are you sure you want to change the base?
Conversation
delete wrong extra tick sign in CLI code
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Overall Summary: The Pull Request titled "Update hello_world.md" contains several key changes that improve the clarity and correctness of the document. These changes include removing an extra tick sign in the CLI code, updating the Go installation link to the official Go website, and fixing formatting by adding a colon after the Upon reviewing the individual summaries provided, it is evident that there are no potential problems or errors identified in this patch. The changes appear to be straightforward and enhance the overall quality of the document. Important Findings:
Based on the provided information, the Pull Request seems to be a valuable contribution and can be merged into the codebase without any potential issues. DetailsCommit 6fd39b2e386036742eed4e76cf9db2509f93f75eKey changes:
Potential problems:
Commit 41033e1722dfc573bd796cb5f4de39baf42e6452Key changes:
Potential problems:
|
docs/develop/go/hello_world.md
Outdated
@@ -115,7 +115,7 @@ $ wasmedge hello.wasm | |||
Hello TinyGo from WasmEdge! | |||
``` | |||
|
|||
For the `--reactor` mode, | |||
For the `--reactor` mode: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahndmal Comma punctuation is well suited in this case. So could you please revert that one? The other change regarding extra backtick looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @adithyaakrishna !
Sure, changed it back to comma :) Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hydai Could you please take another look at this PR :)
The DCO check failed. Please refer to this for signing DCO: https://www.secondstate.io/articles/dco/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. However, the DCO failed.
@ahndmal Could you please sign-off your commits? More info on how to: https://github.com/WasmEdge/docs/pull/178/checks?check_run_id=17924620845 |
changed back semicolon to comma Signed-off-by: andrii <quadr988@gmail.com>
Signed the commits. |
Please squash your commits. One of your commits is not DCO-signed. |
Hi @ahndmal Could you please take a look at the DCO issue? It still fails. Thanks! |
delete wrong extra tick sign in CLI code
Explanation
Correct the CLI cocde in docs.
Related issue
No existing issue
What type of PR is this
/kind documentation
Proposed Changes
Correct the CLI cocde in docs.