Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hello_world.md #178

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update hello_world.md #178

wants to merge 2 commits into from

Conversation

ahndmal
Copy link

@ahndmal ahndmal commented Oct 21, 2023

delete wrong extra tick sign in CLI code

Explanation

Correct the CLI cocde in docs.

Related issue

No existing issue

What type of PR is this

/kind documentation

Proposed Changes

Correct the CLI cocde in docs.

delete wrong extra tick sign in CLI code
Copy link
Collaborator

alabulei1 commented Oct 21, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Overall Summary:

The Pull Request titled "Update hello_world.md" contains several key changes that improve the clarity and correctness of the document. These changes include removing an extra tick sign in the CLI code, updating the Go installation link to the official Go website, and fixing formatting by adding a colon after the --reactor mode.

Upon reviewing the individual summaries provided, it is evident that there are no potential problems or errors identified in this patch. The changes appear to be straightforward and enhance the overall quality of the document.

Important Findings:

  • The key changes focus on improving clarity and correctness.
  • The removal of an extra tick sign in the CLI code enhances the accuracy of the provided code snippet.
  • The update of the Go installation link to the official Go website ensures that users are directed to the most reliable and up-to-date resource.
  • The fix in formatting by adding a colon after the --reactor mode improves the readability and consistency of the document.

Based on the provided information, the Pull Request seems to be a valuable contribution and can be merged into the codebase without any potential issues.

Details

Commit 6fd39b2e386036742eed4e76cf9db2509f93f75e

Key changes:

  • Remove an extra tick sign in the CLI code.
  • Update the Go installation link to the official Go website.
  • Fix formatting by adding a colon after the --reactor mode.

Potential problems:

  • There are no potential problems identified in this patch. The changes appear to be straightforward and improve the clarity and correctness of the document.

Commit 41033e1722dfc573bd796cb5f4de39baf42e6452

Key changes:

  • A semicolon in the line "For the --reactor mode" has been changed to a comma.

Potential problems:

  • No potential problems have been identified in this patch.

@@ -115,7 +115,7 @@ $ wasmedge hello.wasm
Hello TinyGo from WasmEdge!
```

For the `--reactor` mode,
For the `--reactor` mode:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahndmal Comma punctuation is well suited in this case. So could you please revert that one? The other change regarding extra backtick looks good to me

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @adithyaakrishna !
Sure, changed it back to comma :) Thanks

Copy link
Contributor

@adithyaakrishna adithyaakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hydai Could you please take another look at this PR :)

@hydai
Copy link
Member

hydai commented Oct 21, 2023

The DCO check failed. Please refer to this for signing DCO: https://www.secondstate.io/articles/dco/

Copy link
Member

@hydai hydai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. However, the DCO failed.

@adithyaakrishna
Copy link
Contributor

@ahndmal Could you please sign-off your commits? More info on how to: https://github.com/WasmEdge/docs/pull/178/checks?check_run_id=17924620845

changed back semicolon to comma

Signed-off-by: andrii <quadr988@gmail.com>
@ahndmal
Copy link
Author

ahndmal commented Oct 22, 2023

Signed the commits.
Please also note that https://www.secondstate.io/articles/dco/ page seems to have incorrect flags in:
git commit —amend —no-edit ---signoff to be git commit --amend --no-edit --signoff

@hydai
Copy link
Member

hydai commented Oct 26, 2023

Please squash your commits. One of your commits is not DCO-signed.

@alabulei1
Copy link
Collaborator

Hi @ahndmal

Could you please take a look at the DCO issue? It still fails. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants